Refine trigger filter for both PRs and pushes #5619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only one of the trigger conditions had the filter. This is a follow-up to pymc-devs#5364.
michaelosthege
force-pushed
the
ci-refactor
branch
from
04ece5c to
397a374
Compare
michaelosthege
commented
Mar 19, 2022
Comment on lines
-11
to
-12
| - "pyproject.toml" | ||
| - "buildosx" |
Member
Author
There was a problem hiding this comment.
The pyproject.toml is only relevant for the tools running in pre-commit.
The buildosx does not seem to have a purpose. It's 8 years old, was never changed and is not mentioned anywhere in the codebase.
michaelosthege
commented
Mar 19, 2022
| - "*.py" | ||
| - "conda-envs/**" | ||
| - "codecov.yml" | ||
| - "scripts/*.sh" |
Member
Author
There was a problem hiding this comment.
These scripts are involved in creating the test environments.
Codecov Report
@@ Coverage Diff @@
## main #5619 +/- ##
==========================================
+ Coverage 87.67% 87.69% +0.02%
==========================================
Files 76 76
Lines 13717 13717
==========================================
+ Hits 12026 12029 +3
+ Misses 1691 1688 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only one of the trigger conditions had the filter.
This is a follow-up to #5364.
Unfortunately, the changes can't be tested on this PR because of how GitHub determines the diff:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#git-diff-comparisons