Test conditional workflow runs #5364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tried using the info from: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore but doesn't seem to work |
Codecov Report
@@ Coverage Diff @@
## main #5364 +/- ##
==========================================
+ Coverage 80.36% 80.40% +0.03%
==========================================
Files 89 82 -7
Lines 14808 14067 -741
==========================================
- Hits 11901 11311 -590
+ Misses 2907 2756 -151
|
Member
Author
|
If someone can look into the actions thing that would be great, otherwise I'll remove those files from the PR and keep only the removals of unused files |
michaelosthege
approved these changes
Jan 19, 2022
Member
|
For the CI runs here, your changes did not have an effect. Maybe because it need to have been merged first? |
Member
Author
|
Let's try if merging works, good idea |
michaelosthege
added a commit
that referenced
this pull request
Mar 18, 2022
Previously there were two trigger conditions (PRs and pushes to main). With the change all pushes (to PR branches or main) trigger it, and the `paths:` filter applies every time. This is a follow-up to #5364.
michaelosthege
added a commit
to michaelosthege/pymc
that referenced
this pull request
Mar 19, 2022
Previously only one of the trigger conditions had the filter. This is a follow-up to pymc-devs#5364.
michaelosthege
added a commit
that referenced
this pull request
Mar 19, 2022
Previously only one of the trigger conditions had the filter. This is a follow-up to #5364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the opportunity for some cleanup of infrastructure related files