-
Notifications
You must be signed in to change notification settings - Fork 2
Add slt test for pushing volatile predicates down #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This test fails on main like this |
| 03)----TableScan: t_pushdown projection=[a, b] | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192 | ||
| 02)--FilterExec: CAST(b@1 AS Float64) > random(), projection=[a@0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another place where it would be nice to cast expressions instead of data 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All we need is a library that can rewrite expressions ... 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* dissallow pushdown of volatile PhysicalExprs * fix * add FilteredVec helper to handle filter / remap pattern (#34) * checkpoint: Address PR feedback in https://github.com/apach... * add FilteredVec to consolidate handling of filter / remap pattern * lint * Add slt test for pushing volatile predicates down (#35) --------- Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Merging this PR will update apache#16861
Rationale for this change
I think we should have a slt "end to end" reproducer for (not) pushing down volatile predicates
What changes are included in this PR?
Add a slt test
Are these changes tested?
Only tests
Are there any user-facing changes?