add FilteredVec helper to handle filter / remap pattern #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
changed the title
alamb
reviewed
Jul 25, 2025
| /// tracking their original indices, allowing results to be mapped back to the original positions. | ||
| struct FilteredVec<T> { | ||
| items: Vec<T>, | ||
| // Chain of index mappings: each Vec maps from current level to previous level |
There was a problem hiding this comment.
while this multi-level mapping is clever, maybe it could be simpler if we just hard coded the number of levels needed 🤔
Member
Author
There was a problem hiding this comment.
it turns out a bit more complex actually because you need to keep track of 2 states (1 or 2 levels) instead of just multi-level
adriangb
added a commit
that referenced
this pull request
Jul 28, 2025
* checkpoint: Address PR feedback in https://github.com/apach... * add FilteredVec to consolidate handling of filter / remap pattern
adriangb
added a commit
that referenced
this pull request
Jul 30, 2025
* dissallow pushdown of volatile PhysicalExprs * fix * add FilteredVec helper to handle filter / remap pattern (#34) * checkpoint: Address PR feedback in https://github.com/apach... * add FilteredVec to consolidate handling of filter / remap pattern * lint * Add slt test for pushing volatile predicates down (#35) --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.