run gc before benching #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
paf31
reviewed
Jun 11, 2017
src/Performance/Minibench.purs
Outdated
|
|
||
| -- | Force garbage collection. | ||
| -- | Requires node to be run with the --force-gc flag. | ||
| foreign import gc :: forall eff. eff () Unit |
Contributor
There was a problem hiding this comment.
Why not forall eff. Eff eff Unit?
Contributor
Author
There was a problem hiding this comment.
Usually the type checker protects me from my sloppiness... But not always :)
Contributor
Author
|
@paf31 Just a gentle ping on this, as I've been using this lately with List changes, and I believe I've addressed the issue you signaled above. |
paf31
reviewed
Nov 24, 2017
| foreign import hrTime :: forall eff. EffFn1 eff (Array Int) (Array Int) | ||
|
|
||
| -- | Force garbage collection. | ||
| -- | Requires node to be run with the --force-gc flag. |
Contributor
There was a problem hiding this comment.
Maybe this comment should be moved to the top level?
Contributor
|
Thanks! |
Contributor
|
We can change the docs later. |
This was referenced Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2
Did not put in option to run GC during/after benchmarks... Which seems less important, but maybe something to do in the future.