pw_hash: add support for bcrypt variants #1173
Conversation
pw_hash is a functionBreaking changes to this file MAY impact these 11 modules (near match):This module is declared in 318 of 576 indexed public
|
|
(This is a good candidate for squashing commits when merging :-) |
|
@kjetilho Just one small comment, everything else look's good and I'll happily merge once it's resolved. |
kjetilho
force-pushed
the
feature/pw_hash_bcrypt
branch
from
f3800aa to
d5286ce
Compare
|
So with the last changes, Travis here reports
The tests run nicely in my CentOS 8 and Ubuntu Focal test environments, however. |
|
I can squash commits into one feature patch commit and one commit for the documentation update if desired. |
|
Hi @kjetilho, sounds perfect! Thank you for your contribution ! |
This is the hash algorithm used by default by Elasticsearch among others
The return type is not a (Puppet) hash, but a normal text string.
* check for invalid salt values for all bcrypt variants * check for valid return value on glibc 2.28 I am not entirely sure this cutoff is correct, but RHEL 8 runs glibc 2.28 and supports bcrypt, and Ubuntu 18.04 Bionic has glibc 2.27 and does not. Ubuntu Focal 20.04 has glibc 2.31 and also supports bcrypt. We will see what the test harness reports :-)
kjetilho
force-pushed
the
feature/pw_hash_bcrypt
branch
from
51c9d28 to
ffc6d96
Compare
|
Rebased and squashed down, ready for merge. |
|
@kjetilho A few transient failures but rekicking sorted them out. |
4 participants
No description provided.