use versioncmp rather than writing it out as plain code

Author: kjetilho

spec/functions/pw_hash_spec.rb

@@ -66,8 +66,7 @@
 
   begin
     require 'etc'
-    if Etc.confstr(Etc::CS_GNU_LIBC_VERSION) =~ %r{(\d+)\.(\d+)} &&
-       (Regexp.last_match(1).to_i > 2 || (Regexp.last_match(1).to_i == 2 && Regexp.last_match(2).to_i >= 28))
+    if Etc.confstr(Etc::CS_GNU_LIBC_VERSION) =~ %r{(\d+\.\d+)} && Puppet::Util::Package.versioncmp(Regexp.last_match(1), '2.28') >= 0
       context 'when running on platform with bcrypt' do
         it { is_expected.to run.with_params('password', 'bcrypt', '05$salt.salt.salt.salt.sa').and_return('$2b$05$salt.salt.salt.salt.sO5QUgeeLRANZyvfNiKJW5amLo3cVD8nW') }
         it { is_expected.to run.with_params('password', 'bcrypt-a', '05$salt.salt.salt.salt.sa').and_return('$2a$05$salt.salt.salt.salt.sO5QUgeeLRANZyvfNiKJW5amLo3cVD8nW') }