Skip to content

(CAT-1351) - Fixing unsafe interpolation puppet-linting #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

Ramesh7
Copy link

@Ramesh7 Ramesh7 commented Aug 28, 2023

Summary

Recently rolled-out puppet-lint gem checking title as well for unsafe interpolation which seems to be a issue with feature so, downgrading the gem version to avoid the unsafe interpolation issue for title.
Have reported the same to Team.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

  • N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 requested review from bastelfreak, smortex and a team as code owners August 28, 2023 03:36
Copy link
Member

@malikparvez malikparvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Ramesh7 Ramesh7 merged commit 52634cf into main Aug 29, 2023
@Ramesh7 Ramesh7 deleted the CAT-1351 branch August 29, 2023 13:22
@smortex
Copy link
Collaborator

smortex commented Aug 29, 2023

The title look wrong: this does not "fix" something, rather "disable" or "revert" it. @Ramesh7, do you mind adjusting it so that when going through the changelog people better understand what is going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants