(CAT-1351) - Fixing unsafe interpolation puppet-linting

Author: Ramesh7

manifests/mark.pp

@@ -30,7 +30,7 @@
   $onlyif_cmd = [['/usr/bin/dpkg', '-l', $title]]
   $command = ['/usr/bin/apt-mark', $setting, $title]
 
-  exec { "apt-mark ${setting} ${title}":
+  exec { ['apt-mark', $setting, $title]:
     command => $command,
     onlyif  => $onlyif_cmd,
     unless  => $unless_cmd,

manifests/ppa.pp

@@ -105,7 +105,7 @@
         mode    => '0755',
       }
 
-      exec { "add-apt-repository-${name}":
+      exec { ['add-apt-repository-', $name]:
         environment => $_proxy_env,
         command     => $script_path,
         logoutput   => 'on_failure',

manifests/update.pp

@@ -56,8 +56,9 @@
   } else {
     $_refresh = true
   }
+  $command = [$apt::provider, 'update']
   exec { 'apt_update':
-    command     => "${apt::provider} update",
+    command     => $command,
     loglevel    => $apt::_update['loglevel'],
     logoutput   => 'on_failure',
     refreshonly => $_refresh,