Update History for 2.0 release #1727
Conversation
tpike3
commented
Jul 2, 2023
tpike3
commented
- updated history per Release v2.0 #1707
- included Initialize Solara-based adv_tutorial #1726 assuming integration of adv_tutorial (would wait to merge until Initialize Solara-based adv_tutorial #1726 merged)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2.0 #1727 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 18 18
Lines 1178 1178
Branches 220 220
=======================================
Hits 942 942
Misses 202 202
Partials 34 34 ☔ View full report in Codecov by Sentry. |
HISTORY.rst
Outdated
| * space: change `coord_iter` to return `(content,(x,y))` instead of `(content, [x],[y])`; this reduces known errors of scheduler to grid mismatch #1566, #1723 | ||
| * space: change NetworkGrid `get_neighbors` to `get_neighborhood`; improves performance #1542 | ||
| * space: raise exception when pos is out of bounds in `Grid.get_neighborhood` #1524 | ||
| * space: remove deprecations (`find_empty` -> `move_to_empty`, num_agents -> removed param from `move_to_empty`, `position_agent` -> `place_agent`, `neighbor_iter` -> `iter_neighborhood`); complete deprecated function removal #1520, #1687, #1688 |
There was a problem hiding this comment.
Line 18? what if it reads as
space: remove deprecations (use move_to_empty instead of find_empty, use position_agent instead of place_agent use iter_neighborhood instead of neighbor_iter; move_to_empty no longer has the parameter num_agents (int)); complete deprecated function removal #1520, #1687, #1688
There was a problem hiding this comment.
You could format them as a list (nested). This should be considered as a recipe for migration. As such, you should say the obsolete function first, then the replacer, because people are going to follow it step by step.
There was a problem hiding this comment.
There was a problem hiding this comment.
Uh, I meant for it to be read by humans, not LLMs.
I meant list in a list:
- Remove deprecated functions.
find_empty: convert this tomove_to_emptyposition_agent: convert this toplace_agent
I think it is plausible that the LLMs can automate the migration of existing code, if they are fed the old API and new API data, and the migration guide.
|
Why is the target branch v2.0? Shouldn't it be main? |
@jackiekazil told me to do to v2.0, if I remember correctly that then makes the release easier. |
|
Forgot to update the date |
| * `position_agent()`: convert this to `place_agent` | ||
| * `neighbor_iter()`: convert this to `iter_neighborhood()` | ||
| * batchrunner: remove deprecations #1627 | ||
| * `batchrunner()` and `batchrunnerMP()`: convert these to `batch_run()` |
There was a problem hiding this comment.
Aren't those supposed to be BatchRunner and BatchRunnerMP classes, not functions?
| * `neighbor_iter()`: convert this to `iter_neighborhood()` | ||
| * batchrunner: remove deprecations #1627 | ||
| * `batchrunner()` and `batchrunnerMP()`: convert these to `batch_run()` | ||
| * visualization: remove `UserSettableParameter`; easier visualization creation #1693 |
There was a problem hiding this comment.
This is too terse. I will have no idea what to replace UserSettableParameter with.
There was a problem hiding this comment.
I put in some changes feel free to edit as well so we can get this out the door.
|
@tpike3, @rht I changed the target branch to Main -- rht is right. We never updated v2.0. #1726 was merged. @tpike3 is everything tagged with the milestone? |
Changed the date to Saturday the 15th |
|
Is there a reason this was closed?
|
Apologies was rushing this was superseded by #1731 -- merge into main instead of v2.0 |
3 participants
