Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented May 9, 2023

No description provided.

@rht rht changed the title space: Remove deprecations (find_empty, num_agents, position_agent) breaking: space: Remove deprecations (find_empty, num_agents, position_agent) May 12, 2023
@rht rht force-pushed the remove_deprecations branch from 5a028d6 to 1d04e65 Compare May 12, 2023 06:37
@tpike3 tpike3 requested a review from jackiekazil June 10, 2023 12:25
@rht rht force-pushed the remove_deprecations branch 2 times, most recently from f1d9058 to c52d668 Compare June 17, 2023 07:36
@rht rht force-pushed the remove_deprecations branch from c52d668 to 20ef160 Compare June 17, 2023 23:58
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.17 ⚠️

Comparison is base (000408d) 81.56% compared to head (20ef160) 80.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   81.56%   80.39%   -1.17%     
==========================================
  Files          18       18              
  Lines        1410     1229     -181     
  Branches      273      235      -38     
==========================================
- Hits         1150      988     -162     
+ Misses        214      204      -10     
+ Partials       46       37       -9     
Impacted Files Coverage Δ
mesa/space.py 91.33% <ø> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht
Copy link
Contributor Author

rht commented Jun 18, 2023

I have fixed the CI errors.

@rht rht mentioned this pull request Jun 21, 2023
@tpike3 tpike3 added this to the Mesa 2.0 milestone Jun 21, 2023
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 0db8f7c into projectmesa:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants