Skip to content

Conversation

@OnexiMedina
Copy link
Contributor

Addresses #1225

Changes:

I changed the Spanish description of the arc() function (under 2D primitives category) in the reference for p5js.org, as it was previously half-English and half-Spanish.

As for my specific changes, I found that the English description of the function did not completely match the information found in the current Spanish description. Therefore, I proceeded to make a direct translation of the English description as the first paragraph of the new Spanish translation, and formatted the additional information found in the current Spanish description under it. I made the changes in this manner, to maintain the previous information that another contributor took the time to add to the description. Consequently, this resulted in a new description that is longer than the English version for arc(). (See Images below for reference)

Additionally, I made sure to highlight parameter names and provide the correct link for the ellipseMode() function, as it is hyperlinked in the current English description, but not the Spanish one.

@Guirdo and @limzykenneth , please let me know if this style of change aligns with how you would like the descriptions to be formatted (i.e. Doing a 1-to-1 translation of the English description and retaining additional information found in the current Spanish version after). In the meantime, I will continue to work on changes for the rest of the functions under the 2D primitives category. Hope this helps!

Screenshots of the change:

English arc() description

Screenshot 2023-08-02 at 3 53 28 PM

Current Spanish arc() description

Screenshot 2023-08-02 at 3 53 39 PM

New Spanish arc() Description

Screenshot 2023-08-02 at 3 53 56 PM

@Qianqianye
Copy link
Contributor

Thanks @OnexiMedina. I'm tagging the Spanish translation stewards to review the PR @Guirdo, @Andreu-G, @dnd-alv, @holomorfo

Copy link
Contributor

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is correct

@limzykenneth limzykenneth merged commit 474abde into processing:main Aug 18, 2023
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants