-
Notifications
You must be signed in to change notification settings - Fork 645
Revert "primer_react_select_panel_order_selected_at_top off by default" #6026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the default behavior change for the primer_react_select_panel_order_selected_at_top feature flag that was flipped off in a previous patch, restoring it to on by default.
- Restores
primer_react_select_panel_order_selected_at_topdefault totrue - Removes the outdated changeset that turned the flag off without adding a revert changeset entry
Reviewed Changes
Copilot reviewed 186 out of 186 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Changed default for primer_react_select_panel_order_selected_at_top from false back to true |
| .changeset/shaky-streets-joke.md | Deleted the previous patch description but did not add a revert changeset |
Comments suppressed due to low confidence (2)
.changeset/shaky-streets-joke.md:1
- The changeset file was cleared but no new changeset was added to document this revert; please add a proper revert changeset or remove the empty file.
(file is now empty after removals)
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts:10
- [nitpick] Since the default value for this feature flag has changed back, consider adding or updating tests to cover both the enabled and disabled default states.
primer_react_select_panel_order_selected_at_top: true,
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376881 |
|
🟢 golden-jobs completed with status |
Reverts #6024