Skip to content

Conversation

@francinelucca
Copy link
Member

Reverts #6024

Copilot AI review requested due to automatic review settings May 8, 2025 01:31
@francinelucca francinelucca requested review from a team as code owners May 8, 2025 01:31
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: 8ca0010

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the default behavior change for the primer_react_select_panel_order_selected_at_top feature flag that was flipped off in a previous patch, restoring it to on by default.

  • Restores primer_react_select_panel_order_selected_at_top default to true
  • Removes the outdated changeset that turned the flag off without adding a revert changeset entry

Reviewed Changes

Copilot reviewed 186 out of 186 changed files in this pull request and generated no comments.

File Description
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Changed default for primer_react_select_panel_order_selected_at_top from false back to true
.changeset/shaky-streets-joke.md Deleted the previous patch description but did not add a revert changeset
Comments suppressed due to low confidence (2)

.changeset/shaky-streets-joke.md:1

  • The changeset file was cleared but no new changeset was added to document this revert; please add a proper revert changeset or remove the empty file.
(file is now empty after removals)

packages/react/src/FeatureFlags/DefaultFeatureFlags.ts:10

  • [nitpick] Since the default value for this feature flag has changed back, consider adding or updating tests to cover both the enabled and disabled default states.
primer_react_select_panel_order_selected_at_top: true,

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.68 KB (+0.14% 🔺)
packages/react/dist/browser.umd.js 98.91 KB (+0.15% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376881

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 8, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants