primer_react_select_panel_order_selected_at_top off by default #6024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default value of the primer_react_select_panel_order_selected_at_top feature flag to be off by default.
- Changed the default for
primer_react_select_panel_order_selected_at_topfromtruetofalse
Comments suppressed due to low confidence (1)
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts:10
- Add or update a test to verify that
primer_react_select_panel_order_selected_at_topdefaults tofalseas intended.
primer_react_select_panel_order_selected_at_top: false,
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
🦋 Changeset detectedLatest commit: dfc7e5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TylerJDev
approved these changes
May 7, 2025
Contributor
size-limit report 📦
|
francinelucca
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
jonrohan
pushed a commit
that referenced
this pull request
May 9, 2025
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to originally have this FF on by default in sb but ran into integration issues with dotcom where it was not letting me turn it off, so setting it back to false.
Changelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist