Skip to content

Conversation

@TylerJDev
Copy link
Member

Fixes FF typo primer_react_select_panel_modern_action_list

Changelog

Changed

  • Fixes typo

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested review from Copilot and francinelucca May 6, 2025 17:42
@TylerJDev TylerJDev requested a review from a team as a code owner May 6, 2025 17:42
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: 95f74e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 6, 2025
@TylerJDev TylerJDev mentioned this pull request May 6, 2025
13 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the feature flag key used by SelectPanel and adjusts the Storybook preview setup.

  • Renamed the feature flag key for the modern action list in SelectPanel.tsx
  • Updated the FeatureFlags wrapper in Storybook’s preview to remove the explicit flags prop

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/SelectPanel/SelectPanel.tsx Corrected feature flag key to primer_react_select_panel_with_modern_action_list
packages/react/.storybook/preview.jsx Removed the flags prop from the FeatureFlags wrapper
Comments suppressed due to low confidence (1)

packages/react/.storybook/preview.jsx:306

  • The FeatureFlags component no longer receives a flags prop, so no feature flags are being applied in Storybook. Re-add the flags prop with the required flags (e.g., { primer_react_action_list_item_as_button: true, primer_react_select_panel_with_modern_action_list: true }).
<FeatureFlags>

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label May 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.89 KB (-0.16% 🔽)
packages/react/dist/browser.umd.js 99.12 KB (-0.01% 🔽)

@TylerJDev TylerJDev added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 1925d80 May 6, 2025
51 of 52 checks passed
@TylerJDev TylerJDev deleted the fix-selectpanel-FF-typo branch May 6, 2025 20:04
hectahertz pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants