-
Notifications
You must be signed in to change notification settings - Fork 646
SelectPanel: Fix typo with FF name #6012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a typo in the feature flag key used by SelectPanel and adjusts the Storybook preview setup.
- Renamed the feature flag key for the modern action list in SelectPanel.tsx
- Updated the FeatureFlags wrapper in Storybook’s preview to remove the explicit flags prop
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Corrected feature flag key to primer_react_select_panel_with_modern_action_list |
| packages/react/.storybook/preview.jsx | Removed the flags prop from the FeatureFlags wrapper |
Comments suppressed due to low confidence (1)
packages/react/.storybook/preview.jsx:306
- The
FeatureFlagscomponent no longer receives aflagsprop, so no feature flags are being applied in Storybook. Re-add theflagsprop with the required flags (e.g.,{ primer_react_action_list_item_as_button: true, primer_react_select_panel_with_modern_action_list: true }).
<FeatureFlags>
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Fixes FF typo
primer_react_select_panel_modern_action_listChangelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist