Skip to content

SelectPanel: Fix typo with FF name #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

SelectPanel: Fix typo with FF name #5938

wants to merge 6 commits into from

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Apr 18, 2025 •
edited
Loading

Fixes FF typo primer_react_select_panel_modern_action_list

Changelog

Changed

  • Fixes typo

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5114bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev requested a review from francinelucca April 18, 2025 12:12
@TylerJDev TylerJDev marked this pull request as ready for review April 18, 2025 12:12
Copilot AI review requested due to automatic review settings April 18, 2025 12:12
@TylerJDev TylerJDev requested a review from a team as a code owner April 18, 2025 12:12
@github-actions github-actions bot added the staff Author is a staff member label Apr 18, 2025
Copilot AI reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the modern ActionList feature flag for the SelectPanel component in Storybook and fixes a typo in the flag name.

  • Enables the feature flag 'primer_react_select_panel_with_modern_action_list' by default in the SelectPanel component.
  • Updates the Storybook preview to use the same accurate feature flag.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/SelectPanel/SelectPanel.tsx Updates the feature flag reference to use the correct flag name.
packages/react/.storybook/preview.jsx Aligns the feature flag in the Storybook decorators with the updated flag name.

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Apr 18, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.89 KB (-0.16% 🔽)
packages/react/dist/browser.umd.js 99.12 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5938 April 18, 2025 12:26 Inactive
hectahertz
hectahertz approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes please — Thanks!

@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 18, 2025
@primer primer bot requested a review from a team as a code owner April 18, 2025 16:03
@primer primer bot requested a review from mperrotti April 18, 2025 16:03
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 18, 2025
francinelucca
francinelucca reviewed Apr 18, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longshot but is there anyway to still keep vrt for non-modern version? 👀
I'd like to make sure we continue to support both until we're ready to remove the FF and the VRTs are a nice gut check.

Also can you clarify why primer_react_action_list_item_as_button is no longer needed to be default on? 👀

francinelucca
francinelucca reviewed Apr 18, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also let's make sure to spot test the announcements with FF on/off since there was a typo in the name

@TylerJDev
Copy link
Member Author

TylerJDev commented Apr 18, 2025

longshot but is there anyway to still keep vrt for non-modern version? 👀 I'd like to make sure we continue to support both until we're ready to remove the FF and the VRTs are a nice gut check.

Also can you clarify why primer_react_action_list_item_as_button is no longer needed to be default on? 👀

Good point! Let me look to see if there's a way 👀

@TylerJDev
Copy link
Member Author

TylerJDev commented Apr 22, 2025

Also can you clarify why primer_react_action_list_item_as_button is no longer needed to be default on? 👀

This is a FF we need to remove since the functionality is now bundled up in the ActionList CSS modules GA FF.

@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 6, 2025
@TylerJDev TylerJDev changed the title SelectPanel: Enable modern ActionList FF by default in Storybook SelectPanel: Fix typo with FF name May 6, 2025
@TylerJDev TylerJDev removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 6, 2025
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 6, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 6, 2025
@TylerJDev
Copy link
Member Author

TylerJDev commented May 6, 2025

Continued in #6012

@TylerJDev TylerJDev closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francinelucca francinelucca francinelucca left review comments

Copilot code review Copilot Copilot left review comments

@hectahertz hectahertz hectahertz approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TylerJDev @hectahertz @francinelucca