Skip to content

Add Figma Code connect PageHeader #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025
Merged

Add Figma Code connect PageHeader #5757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85c8704
workin on PageHeader
lukasoppermann Mar 7, 2025
c01ceb9
add code connect for PageHeader
lukasoppermann Mar 11, 2025
14071b5
Merge branch 'main' into codeConnect-PageHeader
lukasoppermann Mar 11, 2025
1f20f83
Merge branch 'main' into codeConnect-PageHeader
lukasoppermann Mar 17, 2025
f710eb5
Merge branch 'main' into codeConnect-PageHeader
lukasoppermann Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/Button/IconButton.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ figma.connect(
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=30468-5843&t=eGzObFz2btFEDDNj-4',
{
props: {
icon: figma.instance<React.FunctionComponent>('icon'),
icon: figma.instance('icon').getProps<{name: string; fn: React.FC}>(),
variant: figma.enum<VariantType>('variant', {
primary: 'primary',
secondary: 'default',
Expand All @@ -23,7 +23,7 @@ figma.connect(
ariaLabel: figma.string('aria-label'),
},
example: ({icon, ariaLabel, variant, size}) => (
<IconButton variant={variant} icon={icon} aria-label={ariaLabel} size={size} />
<IconButton variant={variant} icon={icon.fn} aria-label={ariaLabel} size={size} />
),
},
)
186 changes: 174 additions & 12 deletions packages/react/src/PageHeader/PageHeader.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,177 @@ import React from 'react'
import {PageHeader} from '../'
import figma from '@figma/code-connect'

figma.connect(PageHeader, 'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380%3A2926', {
props: {
// No matching props could be found for these Figma properties:
description: figma.boolean('hasDescription', {
false: undefined,
true: figma.children('_PageHeader.Description'),
}),
// "hasNavigation": figma.boolean('hasNavigation'),
// "hasContextArea": figma.boolean('hasContextArea')
},
example: ({description}) => <PageHeader>{description}</PageHeader>,
})
figma.connect(
PageHeader,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40002-2161&t=IXcS4U90x9HnYx6s-4',
{
props: {
// No matching props could be found for these Figma properties:
description: figma.children('_PageHeader.Description'),
titleArea: figma.children('_PageHeader.TitleArea'),
hasBorder: figma.boolean('hasBorder?'),
navigation: figma.children('_PageHeader.Navigation'),
contextArea: figma.children('_PageHeader.ContextArea'),
},
example: ({description, hasBorder, titleArea, navigation, contextArea}) => (
<PageHeader hasBorder={hasBorder}>
Copy link
Member

@joshblack joshblack Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like TypeScript is complaining about hasBorder here, what is the corresponding prop for this in React? I couldn't seem to find a reference for borders in PageHeader 🤔

Copy link
Contributor Author

@lukasoppermann lukasoppermann Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the corresponding prop, I just wait for it to get merged. 😄

{titleArea}
{contextArea}
{description}
{navigation}
</PageHeader>
),
},
)

/* TITLE AREA */
figma.connect(
PageHeader.TitleArea,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380-2931&m=dev',
{
props: {
variant: figma.enum('Title size', {
subtitle: 'subtitle',
medium: 'medium',
large: 'large',
}),
title: figma.children('_PageHeader.Title'),
actions: figma.children('_PageHeader.Actions'),
leadingAction: figma.children('_PageHeader.LeadingAction'),
trailingAction: figma.children('_PageHeader.TrailingAction'),
leadingVisual: figma.children('_PageHeader.LeadingVisual'),
trailingVisual: figma.children('_PageHeader.TrailingVisual'),
},
example: ({variant, title, actions, leadingAction, trailingAction, leadingVisual, trailingVisual}) => (
<>
<PageHeader.TitleArea variant={variant}>
{leadingVisual}
{title}
{trailingVisual}
</PageHeader.TitleArea>
{leadingAction}
{trailingAction}
{actions}
</>
),
},
)

/* TITLE */
figma.connect(
PageHeader.Title,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380-2888&m=dev',
{
props: {
title: figma.string('title'),
},
example: ({title}) => <PageHeader.Title>{title}</PageHeader.Title>,
},
)

/* Actions */
figma.connect(
PageHeader.Actions,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=39970-89643&t=fprKViURxkKXOe6Y-4',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.Actions>{children}</PageHeader.Actions>,
},
)

/* Description */
figma.connect(
PageHeader.Description,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380-2894&t=IXcS4U90x9HnYx6s-4',
{
example: () => <PageHeader.Description>{/*...*/}</PageHeader.Description>,
},
)

/* Navigation */
figma.connect(
PageHeader.Navigation,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380-2885&t=IXcS4U90x9HnYx6s-4',
{
props: {
underlineNav: figma.nestedProps('UnderlineNav', {
items: figma.children('*'),
}),
},
example: ({underlineNav}) => <PageHeader.Navigation>{underlineNav.items}</PageHeader.Navigation>,
},
)

/* LeadingAction */
figma.connect(
PageHeader.LeadingAction,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40102-162217&t=wRHARmXHLT2f3NjB-4',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.LeadingAction>{children}</PageHeader.LeadingAction>,
},
)

/* TrailingAction */
figma.connect(
PageHeader.TrailingAction,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40102-162780&t=wRHARmXHLT2f3NjB-4',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.TrailingAction>{children}</PageHeader.TrailingAction>,
},
)

/* LeadingVisual */
figma.connect(
PageHeader.LeadingVisual,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40102-163620&m=dev',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.LeadingVisual>{children}</PageHeader.LeadingVisual>,
},
)

/* TrailingVisual */
figma.connect(
PageHeader.TrailingVisual,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40102-163412&m=dev',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.TrailingVisual>{children}</PageHeader.TrailingVisual>,
},
)

/* ContextArea */
figma.connect(
PageHeader.ContextArea,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=38380-2874&t=wRHARmXHLT2f3NjB-4',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.ContextArea>{children}</PageHeader.ContextArea>,
},
)

/* ContextAreaActions */
figma.connect(
PageHeader.ContextAreaActions,
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=40102-164554&t=wRHARmXHLT2f3NjB-4',
{
props: {
children: figma.children('*'),
},
example: ({children}) => <PageHeader.ContextAreaActions>{children}</PageHeader.ContextAreaActions>,
},
)
Loading