Skip to content

Add Figma Code connect PageHeader #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

Add Figma Code connect PageHeader #5757

merged 5 commits into from
Apr 9, 2025

Conversation

@lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Mar 11, 2025 •
edited
Loading

Adds Figma Code connect file for PageHeader

CleanShot 2025-03-11 at 10 01 19@2x

This needs #5741 to be merged as we otherwise get a typescript error.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    → No change to react, the standard process for those changes is to not increase the version.

Testing & Reviewing

Merge checklist

@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Mar 11, 2025
@lukasoppermann lukasoppermann self-assigned this Mar 11, 2025
@lukasoppermann lukasoppermann requested a review from a team as a code owner March 11, 2025 09:00
@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f710eb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

Uh oh! @lukasoppermann, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 5

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.35 KB (0%)
packages/react/dist/browser.umd.js 104.74 KB (0%)

@lukasoppermann lukasoppermann changed the title Add Code connect page header Add Figma Code connect PageHeader Mar 11, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5757 March 11, 2025 09:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5757 March 11, 2025 09:47 Inactive
@lukasoppermann lukasoppermann enabled auto-merge (squash) March 11, 2025 12:58
joshblack
joshblack reviewed Mar 11, 2025
View reviewed changes
packages/react/src/PageHeader/PageHeader.figma.tsx
contextArea: figma.children('_PageHeader.ContextArea'),
},
example: ({description, hasBorder, titleArea, navigation, contextArea}) => (
<PageHeader hasBorder={hasBorder}>
Copy link
Member

@joshblack joshblack Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like TypeScript is complaining about hasBorder here, what is the corresponding prop for this in React? I couldn't seem to find a reference for borders in PageHeader 🤔

Copy link
Contributor Author

@lukasoppermann lukasoppermann Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the corresponding prop, I just wait for it to get merged. 😄

@github-actions github-actions bot temporarily deployed to storybook-preview-5757 March 17, 2025 09:21 Inactive
@lukasoppermann lukasoppermann removed the request for review from siddharthkp April 9, 2025 10:57
@lukasoppermann lukasoppermann disabled auto-merge April 9, 2025 10:57
@lukasoppermann lukasoppermann added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 682814c Apr 9, 2025
44 checks passed
@lukasoppermann lukasoppermann deleted the codeConnect-PageHeader branch April 9, 2025 11:09
jonrohan pushed a commit that referenced this pull request Apr 10, 2025
@lukasoppermann @jonrohan
Add Figma Code connect PageHeader (#5757)
dacc2dd
hectahertz pushed a commit that referenced this pull request May 20, 2025
@lukasoppermann @hectahertz
Add Figma Code connect PageHeader (#5757)
1fa3af6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack left review comments

@francinelucca francinelucca francinelucca approved these changes

Assignees

@lukasoppermann lukasoppermann

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukasoppermann @joshblack @francinelucca