Skip to content

Change button to accept string in count #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Change button to accept string in count #5725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79a1c4b
change button to accept string in count
lukasoppermann Feb 28, 2025
2d3b290
Update .changeset/yellow-trainers-arrive.md
lukasoppermann Mar 17, 2025
21e9aa5
Update packages/react/src/Button/Button.features.stories.tsx
lukasoppermann Mar 17, 2025
2080695
Merge branch 'main' into button-counter-allow-string
lukasoppermann Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-trainers-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Allow button count prop to accept a number or a string, to allow for human format, like 3.2k
4 changes: 4 additions & 0 deletions packages/react/src/Button/Button.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export const TrailingCounter = () => {

export const TrailingCounterWithNoText = () => <Button aria-label="Comments" leadingVisual={CommentIcon} count={3} />

export const TrailingCounterWithHumanFormat = () => (
<Button aria-label="Comments" leadingVisual={CommentIcon} count="3.2k" />
)

export const TrailingCounterAllVariants = () => {
const [count, setCount] = useState(0)
const onClick = () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Button/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export type ButtonProps = {

children?: React.ReactNode

count?: number
count?: number | string
} & ButtonBaseProps

export type IconButtonProps = ButtonA11yProps & {
Expand Down
Loading