Change button to accept string in count #5725
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2080695 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
joshblack
approved these changes
Mar 4, 2025
Member
joshblack
left a comment
joshblack
left a comment
There was a problem hiding this comment.
Looks great! Just left a couple of suggestions
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
hectahertz
pushed a commit
that referenced
this pull request
Mar 20, 2025
Co-authored-by: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the RepoPicker we use a button that shows the count of the selected items. This can easily be more than
1000. SO we would like to use the "human format", like3.2kinstead of3200.This PR allows this by changing the type of count to
number | stringas suggested by @mperrottiChangelog
New
Changed
Type of
countchanged tonumber | stringRemoved
Rollout strategy
Testing & Reviewing
Merge checklist