Skip to content

Fix Prod Storybook deployment #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix Prod Storybook deployment #5535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac74a8
Fix prod storybook deployment
hussam-i-am Jan 13, 2025
8b563bd
Add npm scripts
hussam-i-am Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"start": "concurrently npm:start:*",
"start:storybook": "npm run start:storybook -w @primer/react",
"build:storybook": "script/build-storybook",
"build:storybook:preview": "script/build-storybook preview",
"build:storybook:preview_with_reports": "script/build-storybook preview_with_reports",
"build:docs": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs",
"build:docs:preview": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview",
"build:docs:preview_with_reports": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview_with_reports",
Expand Down
4 changes: 2 additions & 2 deletions script/build-docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ set -e

if [ "$1" == "preview" ]; then
export DEPLOY_ENV="preview"
npm run build:storybook preview
npm run build:storybook:preview
elif [ "$1" == "preview_with_reports" ]; then
export DEPLOY_ENV="preview"
npm run build:storybook preview_with_reports
npm run build:storybook:preview_with_reports
else
export DEPLOY_ENV="production"
npm run build:storybook
Expand Down
2 changes: 1 addition & 1 deletion script/build-storybook
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ npx storybook build -o ../../docs/public/storybook
if [ "$1" == "preview_with_reports" ]; then
# Move index_with_reports.html to the right location
cp .storybook/index_with_reports.html ../../docs/public/index.html
else
elif [ "$1" == "preview" ]; then
# Move index.html to the right location
cp .storybook/index.html ../../docs/public/index.html
fi
Expand Down
Loading