Skip to content

Fix Prod Storybook deployment #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix Prod Storybook deployment #5535

merged 2 commits into from
Jan 13, 2025

Conversation

@hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 13, 2025

Changelog

New

Changed

Updated the build and npm scripts to more explicitly preview and not run for production

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Jan 13, 2025
@hussam-i-am hussam-i-am requested a review from a team as a code owner January 13, 2025 17:17
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 8b563bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (0%)
packages/react/dist/browser.umd.js 104.52 KB (0%)

@joshblack joshblack added the skip changeset This change does not need a changelog label Jan 13, 2025
@hussam-i-am hussam-i-am enabled auto-merge January 13, 2025 17:25
@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 8b96591 Jan 13, 2025
46 of 48 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/fix-prod-storybook branch January 13, 2025 17:35
joshblack added a commit that referenced this pull request Jan 13, 2025
@joshblack
Revert "Fix Prod Storybook deployment (#5535)"
7cc21f8 
This reverts commit 8b96591.
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
@joshblack
revert: restore deploy preview behavior (#5536)
15270ac 
* Revert "Fix Prod Storybook deployment (#5535)"

This reverts commit 8b96591.

* Revert "fix: deploy_preview workflow (#5529)"

This reverts commit be42cc6.

* Revert "Fixing deploy_preview workflow (#5526)"

This reverts commit 62353f2.

* Revert "Remove branch from preview_deploy.yml (#5523)"

This reverts commit e2075bd.

* Revert "Add landing page and upload vrt/aat reports to GitHub Pages (#5499)"

This reverts commit 5a6d7bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hussam-i-am @joshblack