Skip to content

Patch 37.7.2 #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Patch 37.7.2 #5426

wants to merge 6 commits into from

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Dec 12, 2024 •
edited
Loading

v37.7.1 introduced some visual regressions to TokenBase, this pulls the fix into a new patch release,.

Changelog

New

  • Pull in v37.7.1 fixes + new PR fix
  • Update versions to v37.7.2

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

jonrohan and others added 6 commits December 10, 2024 23:56
@jonrohan
Revert "chore(ButtonGroup): Remove the CSS modules feature flag from …
8b4f03c 
…ButtonGroup (#5339)"

This reverts commit dc2f083.
@jonrohan
Revert "BugFix: Use first-of-type for buttongroup selector (#5343)"
3be386c 
This reverts commit 70005b8.
@jonrohan
Add changeset
7d195fc
@jonrohan
@primer/react v37.7.1
b2e1fa5
@TylerDixon @francinelucca
Add className back to TokenBase (#5420)
f2d188f 
* Add className back to TokenBase

* Adding tests and fixing implementation

* Create dirty-wasps-behave.md

---------

Co-authored-by: Marie Lucca <[email protected]>
@francinelucca
version
819ce15
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 819ce15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.51 KB (0%)
packages/react/dist/browser.umd.js 103.78 KB (0%)

@primer-integration
Copy link

primer-integration bot commented Dec 12, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354856

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 12, 2024
@francinelucca
Copy link
Member Author

francinelucca commented Dec 12, 2024

published v37.7.2, closing

@francinelucca francinelucca mentioned this pull request Dec 12, 2024
Merged
@primer-integration
Copy link

primer-integration bot commented Dec 12, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 12, 2024
@francinelucca francinelucca mentioned this pull request Dec 13, 2024
Closed
4 tasks
@francinelucca francinelucca changed the title Patch/37.7.2 Patch 37.7.2 Dec 30, 2024
@jonrohan jonrohan deleted the patch/37.7.2 branch May 9, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francinelucca @jonrohan @TylerDixon