Skip to content

chore(ButtonGroup): Remove the CSS modules feature flag from ButtonGroup #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 5, 2024
Merged

chore(ButtonGroup): Remove the CSS modules feature flag from ButtonGroup #5339

merged 8 commits into from
Dec 5, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 27, 2024 •
edited
Loading

Closes #

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from ButtonGroup

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ef4743e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.93 KB (-0.14% 🔽)
packages/react/dist/browser.umd.js 104.38 KB (-0.13% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5339 November 27, 2024 22:26 Inactive
@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 27, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 27, 2024
@primer primer bot temporarily deployed to github-pages November 27, 2024 22:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5339 November 27, 2024 22:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5339 December 2, 2024 22:35 Inactive
@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 2, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 2, 2024
@jonrohan jonrohan mentioned this pull request Dec 3, 2024
Merged
13 tasks
@github-actions github-actions bot temporarily deployed to storybook-preview-5339 December 3, 2024 01:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5339 December 4, 2024 03:45 Inactive
@primer-integration
Copy link

primer-integration bot commented Dec 4, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353480

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 4, 2024
@primer-integration
Copy link

primer-integration bot commented Dec 5, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 5, 2024
@jonrohan jonrohan marked this pull request as ready for review December 5, 2024 18:11
@jonrohan jonrohan requested review from a team as code owners December 5, 2024 18:11
@jonrohan jonrohan added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit dc2f083 Dec 5, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag_buttongroup branch December 5, 2024 18:33
@primer primer bot mentioned this pull request Dec 5, 2024
Merged
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "chore(ButtonGroup): Remove the CSS modules feature flag from …
598d91f 
…ButtonGroup (#5339)"

This reverts commit dc2f083.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "chore(ButtonGroup): Remove the CSS modules feature flag from …
f96d723 
…ButtonGroup (#5339)"

This reverts commit dc2f083.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "chore(ButtonGroup): Remove the CSS modules feature flag from …
95ead3d 
…ButtonGroup (#5339)"

This reverts commit dc2f083.
jonrohan added a commit that referenced this pull request Dec 10, 2024
@jonrohan
Revert "chore(ButtonGroup): Remove the CSS modules feature flag from …
8b4f03c 
…ButtonGroup (#5339)"

This reverts commit dc2f083.
@jonrohan jonrohan mentioned this pull request Dec 11, 2024
Merged
13 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@jonrohan
Revert ButtonGroup changes from last release 37.7.0 (#5412)
d9e62e9 
* Revert "chore(ButtonGroup): Remove the CSS modules feature flag from ButtonGroup (#5339)"

This reverts commit dc2f083.

* Revert "BugFix: Use first-of-type for buttongroup selector (#5343)"

This reverts commit 70005b8.

* Add changeset

* @primer/react v37.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @joshblack