Skip to content

chore(TreeView): Move TreeView component css module feature flag to staff #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore(TreeView): Move TreeView component css module feature flag to staff #5388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8023e56
Move TreeView to staff
jonrohan Dec 6, 2024
5f64f1c
Create many-pans-tickle.md
jonrohan Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-pans-tickle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Move TreeView component css module feature flag to staff
26 changes: 14 additions & 12 deletions packages/react/src/TreeView/TreeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import {SkeletonText} from '../experimental/Skeleton/SkeletonText'
import {toggleStyledComponent} from '../internal/utils/toggleStyledComponent'
import {useFeatureFlag} from '../FeatureFlags'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'

// ----------------------------------------------------------------------------
// Context

Expand Down Expand Up @@ -78,7 +80,7 @@ export type TreeViewProps = {
const TOGGLE_ICON_SIZE = 12

const UlBox = toggleStyledComponent(
'primer_react_css_modules_team',
CSS_MODULES_FEATURE_FLAG,
'ul',
styled.ul<SxProp>`
list-style: none;
Expand Down Expand Up @@ -338,7 +340,7 @@ const Root: React.FC<TreeViewProps> = ({
expandedStateCache.current = new Map()
}

const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)

return (
<RootContext.Provider
Expand Down Expand Up @@ -484,7 +486,7 @@ const Item = React.forwardRef<HTMLElement, TreeViewItemProps>(
slots.trailingVisual ? trailingVisualId : null,
].filter(Boolean)

const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)

return (
<ItemContext.Provider
Expand Down Expand Up @@ -612,7 +614,7 @@ const Item = React.forwardRef<HTMLElement, TreeViewItemProps>(

/** Lines to indicate the depth of an item in a TreeView */
const LevelIndicatorLines: React.FC<{level: number}> = ({level}) => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
return (
<div style={{width: '100%', display: 'flex'}}>
{Array.from({length: level - 1}).map((_, index) => (
Expand Down Expand Up @@ -767,7 +769,7 @@ function usePreviousValue<T>(value: T): T {
}

const StyledSkeletonItemContainer = toggleStyledComponent(
'primer_react_css_modules_team',
CSS_MODULES_FEATURE_FLAG,
'span',
styled.span.attrs({
className: 'PRIVATE_TreeView-item-skeleton',
Expand Down Expand Up @@ -804,15 +806,15 @@ const StyledSkeletonItemContainer = toggleStyledComponent(
)

const StyledSkeletonText = toggleStyledComponent(
'primer_react_css_modules_team',
CSS_MODULES_FEATURE_FLAG,
SkeletonText,
styled(SkeletonText)`
width: var(--tree-item-loading-width, 67%);
`,
)

const SkeletonItem = () => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
return (
<StyledSkeletonItemContainer
className={clsx(
Expand All @@ -835,7 +837,7 @@ type LoadingItemProps = {

const LoadingItem = React.forwardRef<HTMLElement, LoadingItemProps>(({count}, ref) => {
const itemId = useId()
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)

if (count) {
return (
Expand Down Expand Up @@ -897,7 +899,7 @@ export type TreeViewVisualProps = {
}

const LeadingVisual: React.FC<TreeViewVisualProps> = props => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
const {isExpanded, leadingVisualId} = React.useContext(ItemContext)
const children = typeof props.children === 'function' ? props.children({isExpanded}) : props.children
return (
Expand All @@ -922,7 +924,7 @@ const LeadingVisual: React.FC<TreeViewVisualProps> = props => {
LeadingVisual.displayName = 'TreeView.LeadingVisual'

const TrailingVisual: React.FC<TreeViewVisualProps> = props => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
const {isExpanded, trailingVisualId} = React.useContext(ItemContext)
const children = typeof props.children === 'function' ? props.children({isExpanded}) : props.children
return (
Expand Down Expand Up @@ -950,7 +952,7 @@ TrailingVisual.displayName = 'TreeView.TrailingVisual'
// TreeView.LeadingAction

const LeadingAction: React.FC<TreeViewVisualProps> = props => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
const {isExpanded} = React.useContext(ItemContext)
const children = typeof props.children === 'function' ? props.children({isExpanded}) : props.children
return (
Expand Down Expand Up @@ -978,7 +980,7 @@ LeadingAction.displayName = 'TreeView.LeadingAction'
// TreeView.DirectoryIcon

const DirectoryIcon = () => {
const cssModulesEnabled = useFeatureFlag('primer_react_css_modules_team')
const cssModulesEnabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
const {isExpanded} = React.useContext(ItemContext)
const Icon = isExpanded ? FileDirectoryOpenFillIcon : FileDirectoryFillIcon
return (
Expand Down
Loading