Skip to content

chore(TreeView): Move TreeView component css module feature flag to staff #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore(TreeView): Move TreeView component css module feature flag to staff #5388

merged 2 commits into from
Dec 13, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 6, 2024 •
edited
Loading

Changelog

New

Changed

Move TreeView component css module feature flag to staff

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

This won't require any integration tests since it's a feature flag change.

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5f64f1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5388 December 6, 2024 18:54 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.68 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js 104.05 KB (-0.06% 🔽)

@jonrohan jonrohan removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@jonrohan jonrohan marked this pull request as ready for review December 6, 2024 19:01
@jonrohan jonrohan requested a review from a team as a code owner December 6, 2024 19:01
@jonrohan jonrohan requested a review from mperrotti December 6, 2024 19:01
@jonrohan jonrohan enabled auto-merge December 6, 2024 19:01
@jonrohan jonrohan added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit e3856ba Dec 13, 2024
42 of 43 checks passed
@jonrohan jonrohan deleted the css_module_treeview_staff branch December 13, 2024 18:52
@primer primer bot mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randall-krauskopf randall-krauskopf randall-krauskopf approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

@hussam-i-am hussam-i-am Awaiting requested review from hussam-i-am

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @randall-krauskopf