feat(TextInput): Convert TextInput (Part 2) - Update CSS to use data attributes #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e9f2e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
…am/remove-textinput-width-props
…thub.com/primer/react into hussam-i-am/remove-textinput-width-props
github-actions
bot
added
integration-tests: failing
…thub.com/primer/react into revert-5256-revert-5242-hussam-i-am/text-input-data-attrs
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hussam-i-am
changed the base branch from
main
to
hussam-i-am/remove-textinput-width-props
github-actions
bot
added
integration-tests: passing
…256-revert-5242-hussam-i-am/text-input-data-attrs
hussam-i-am
commented
Nov 12, 2024
| const defaultStyles = renderStyles(<Textarea block />) | ||
| const blockStyles = renderStyles(<Textarea />) | ||
| const defaultStyles = renderStyles(<Textarea />) | ||
| const blockStyles = renderStyles(<Textarea block />) |
Contributor
Author
There was a problem hiding this comment.
Updated so that variable names match component props
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…thub.com/primer/react into revert-5256-revert-5242-hussam-i-am/text-input-data-attrs
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Base automatically changed from
hussam-i-am/remove-textinput-width-props
to
main
November 13, 2024 20:38
…56-revert-5242-hussam-i-am/text-input-data-attrs
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Author
|
Failing integration tests are the same owns failing in main #5276 |
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351099 |
|
🔴 golden-jobs completed with status |
jonrohan
approved these changes
Nov 14, 2024
hussam-i-am
deleted the
revert-5256-revert-5242-hussam-i-am/text-input-data-attrs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Changed
getcalls with CSS variables and removed fallbacksRemoved
Rollout strategy
Testing & Reviewing
Not sure if it is a known issue but it seems that passing in
smallforsizedoes not currently do anything, whereas with the changes made, we are getting smaller inputsMerge checklist