Skip to content

Conversation

@hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Nov 4, 2024

Changelog

New

Changed

  • Updated TextInputWrapper to use CSS modules behind feature flag
  • Partially updated TextInputWithTokens to use CSS modules for TextInputWrapper
  • Updated snapshots

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 4, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 96c2dc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5227 November 4, 2024 22:05 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.49 KB (+0.17% 🔺)
packages/react/dist/browser.umd.js 99.81 KB (+0.15% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5227 November 13, 2024 16:49 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351001

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

Base automatically changed from revert-5256-revert-5242-hussam-i-am/text-input-data-attrs to main November 14, 2024 18:05
@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 1cfbf63 Nov 14, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the css-moduled-text-input branch November 14, 2024 23:05
@primer primer bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants