Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 4, 2024

Changelog

Removed

Remove the CSS modules feature flag from Avatar

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner November 4, 2024 18:57
@jonrohan jonrohan requested a review from TylerJDev November 4, 2024 18:57
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 0e9b331

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.39 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 98.83 KB (-0.04% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 4, 2024 19:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 4, 2024 19:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 4, 2024 19:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 4, 2024 19:32 Inactive
@primer-integration
Copy link

primer-integration bot commented Nov 4, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 4, 2024 22:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 5, 2024 17:40 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349892

@github-actions github-actions bot temporarily deployed to storybook-preview-5221 November 5, 2024 18:13 Inactive
table: {
disable: true,
},
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having type errors when I removed this.

@jonrohan jonrohan added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 11c455c Nov 7, 2024
43 checks passed
@jonrohan jonrohan deleted the remove_css_modules_flag_avatar branch November 7, 2024 17:36
@primer primer bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants