Skip to content

Conversation

@randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Nov 13, 2024

Related To: https://github.com/github/primer/issues/4367

This PR is part 2 of breaking apart a larger PR into grokkable parts.

Apologies for the larger PR but there was an odd interplay with the specificity across the various components that made it hard to break this PR into smaller chunks

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 8cd93d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 00:22 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.99 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 104.29 KB (+0.23% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 00:40 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@joshblack joshblack removed their request for review November 22, 2024 16:37
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353551

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 4, 2024
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 05db651 Dec 4, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the token-css-modules-base-and-token branch December 4, 2024 17:03
@primer primer bot mentioned this pull request Dec 4, 2024
@TylerDixon TylerDixon mentioned this pull request Dec 12, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants