Skip to content

UnderlineNav: Display loading counters only for items with the "counter" prop #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2024
Merged

UnderlineNav: Display loading counters only for items with the "counter" prop #4745

merged 6 commits into from
Nov 12, 2024

Conversation

@cihad
Copy link
Contributor

@cihad cihad commented Jul 17, 2024 •
edited by broccolinisoup
Loading

Resolves #4672

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@cihad cihad requested a review from a team as a code owner July 17, 2024 12:32
@cihad cihad requested a review from camertron July 17, 2024 12:32
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 74ecf17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cihad cihad temporarily deployed to github-pages July 17, 2024 12:36 — with GitHub Actions Inactive
@broccolinisoup broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 19, 2024
broccolinisoup
broccolinisoup requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cihad 👋🏻 Thanks so much for pushing this PR! The changes looks good to me. Could you please add a changeset and fill out the PR description? 🙏🏻

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 19, 2024
@cihad cihad temporarily deployed to github-pages July 19, 2024 09:48 — with GitHub Actions Inactive
@TylerJDev
Copy link
Member

TylerJDev commented Sep 13, 2024

Hey @cihad! Just wanted to follow-up and see if you were still working on this PR? I see it's nearly finished, it looks like it just needs a changeset and an update to your PR description. Thank you too for your contribution!

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 5, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 5, 2024
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 5, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 5, 2024
@joshblack joshblack requested a review from a team as a code owner November 5, 2024 21:07
@joshblack joshblack requested a review from tbenning November 5, 2024 21:07
broccolinisoup
broccolinisoup reviewed Nov 12, 2024
View reviewed changes
@broccolinisoup broccolinisoup changed the title Resolves #4672 UnderlineNav: Display loading counters only for items with the "counter" prop Nov 12, 2024
@broccolinisoup broccolinisoup self-requested a review November 12, 2024 01:23
@broccolinisoup broccolinisoup added this pull request to the merge queue Nov 12, 2024
Merged via the queue into primer:main with commit 3f508c7 Nov 12, 2024
42 of 43 checks passed
@primer primer bot mentioned this pull request Nov 12, 2024
Merged
@primer-integration
Copy link

primer-integration bot commented Nov 12, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350811

@primer-integration
Copy link

primer-integration bot commented Nov 12, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<UnderlineNav.Item /> without counter shows loading indicator

5 participants

@cihad @TylerJDev @broccolinisoup @joshblack @langermank