Skip to content

<UnderlineNav.Item /> without counter shows loading indicator #4672

@cihad

Description

@cihad

Description

If loadingCounters is true and an UnderlineNav.Item does not have a counter prop, the loading indicator is shown. Normally, if there are 10 items, if 1 or 2 of them do not have a counter prop, it does not pose a problem. But if there are no counters in 5 of them, it is not a nice view.

loadingCounters: true:

Screenshot 2024-06-14 115757

loadingCounters: false:
Screenshot 2024-06-14 115648

Steps to reproduce

Sample view:

<UnderlineNav aria-label="Repository" loadingCounters={true}>
  <UnderlineNav.Item>Inspect</UnderlineNav.Item>
  <UnderlineNav.Item counter={0}>Resources</UnderlineNav.Item>
  <UnderlineNav.Item counter={0}>Packages</UnderlineNav.Item>
  <UnderlineNav.Item>Code</UnderlineNav.Item>
  <UnderlineNav.Item>Docs</UnderlineNav.Item>
  <UnderlineNav.Item>Debug</UnderlineNav.Item>
</UnderlineNav>

Version

36.7.1

Browser

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreact

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions