Skip to content

Import Primitives v8 colors into Storybook #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 21, 2024
Merged

Import Primitives v8 colors into Storybook #4352

merged 17 commits into from
Mar 21, 2024

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Mar 5, 2024 •
edited
Loading

Enables v8 colors in Storybook to match dotcom production (GA March 19th)

Since there's so many snapshot updates, it's probably easier to just take a spin through the deployed Storybook using the all color theme and looking at critical components.

Closes #4356

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bd44334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.6 KB (0%)
packages/react/dist/browser.umd.js 88.79 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 5, 2024 00:21 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 5, 2024
@primer primer bot temporarily deployed to github-pages March 5, 2024 00:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 5, 2024 00:29 Inactive
@langermank langermank added the skip changeset This change does not need a changelog label Mar 5, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 5, 2024 22:33 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 5, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 5, 2024
@primer primer bot temporarily deployed to github-pages March 5, 2024 22:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 5, 2024 22:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 6, 2024 01:21 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 6, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 6, 2024
@langermank langermank mentioned this pull request Mar 12, 2024
Merged
13 tasks
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 15, 2024 16:53 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 15, 2024
@primer primer bot temporarily deployed to github-pages March 15, 2024 16:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 15, 2024 16:59 Inactive
@langermank langermank marked this pull request as ready for review March 15, 2024 17:13
@langermank langermank requested review from a team as code owners March 15, 2024 17:13
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 21, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4352 March 21, 2024 17:23 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 21, 2024
@langermank langermank added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit f19ebdf Mar 21, 2024
@langermank langermank deleted the prim-v8-storybook branch March 21, 2024 17:49
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
@langermank @lukasoppermann
Import Primitives v8 colors into Storybook (#4352)
1b61c60 
* trigger snapshots

* import v8

* test(vrt): update snapshots

* testing

* lock

* test(vrt): update snapshots

* bump

* lock

* bump

* bump

* test(vrt): update snapshots

* bump

* test(vrt): update snapshots

---------

Co-authored-by: langermank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasoppermann lukasoppermann lukasoppermann approved these changes

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

@owenniblock owenniblock Awaiting requested review from owenniblock owenniblock is a code owner automatically assigned from primer/engineer-reviewers

+1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disabled inputs look the same as enabled inputs in dark themes

4 participants

@langermank @keithamus @lukasoppermann