Bug fix: default Button disabled bg-color #4379
Conversation
🦋 Changeset detectedLatest commit: 2516a21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
added
the
update snapshots
size-limit report 📦
|
github-actions
bot
removed
the
update snapshots
| .c0:disabled [data-component=ButtonCounter] { | ||
| color: inherit; | ||
| background-color: var(--button-default-bgColor-disabled,undefined); |
There was a problem hiding this comment.
This seems weird, but noticing the rest of the snapshot has similar undefined 🤷🏻
There was a problem hiding this comment.
Oh.. that's not good. Investigating
There was a problem hiding this comment.
Actually, this looks like a normal thing that happens. I tested it in Storybook and the value is there. Its not great but we're getting rid of snaps soon anyways. Thanks for flagging!
There was a problem hiding this comment.
I made a very similar comment. Ignore me if this is expected behavior.
| '&:disabled': { | ||
| color: 'primer.fg.disabled', | ||
| borderColor: `var(--button-default-borderColor-disabled, ${theme?.colors.btn.border})`, | ||
| backgroundColor: `var(--button-default-bgColor-disabled, ${theme?.colors.input.disabledBg})`, |
There was a problem hiding this comment.
Are we sure theme.colors.input.disabledBg is the right path for the fallback? It's rendering as undefined in the Jest snapshot tests.
There was a problem hiding this comment.
It looks like the border color above is also undefined, so I assumed there's something up with the test
* btn bg + stories * Create young-cooks-shave.md * test(vrt): update snapshots * snippy snappers * move bg color --------- Co-authored-by: langermank <[email protected]>
background-colorfor the default Button disabled stateRollout strategy
Testing & Reviewing
Merge checklist