Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Dec 20, 2023

Easy peasy! Kudos to @broccolinisoup!

Warning

We might want to wait until we adopt Tooltip v2 in TextInput.Action OR match the arrow design between the 2 Tooltips to make sure the Tooltips mach, will wait for @broccolinisoup's input on which direction to take

different.tooltips.mov

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2023

⚠️ No Changeset found

Latest commit: 0128d1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Dec 20, 2023
@siddharthkp siddharthkp self-assigned this Dec 20, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.75 KB (0%)
dist/browser.umd.js 105.3 KB (0%)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww exciting!! Just adding a comment to make the usages compatible with the new Tooltip:

<Box>
  {onClearSelection ? (
    <Tooltip text="Clear selection" type="label">
      <IconButton type="button" variant="invisible" icon={FilterRemoveIcon} aria-label="Clear selection" onClick={onClearSelection} />
    </Tooltip>
  ) : null}
  <Tooltip text="Close" type="label">
    <IconButton type="button" variant="invisible" icon={XIcon} aria-label="Close" onClick={() => onCancel()} />
  </Tooltip>
</Box>
  • Added type="label" (prop reference)
  • Removed the direction because it defaults to s
  • Moved the Onclick event to the button from the tooltip

@broccolinisoup
Copy link
Member

I pushed a PR for updating the TextInput.Action tooltip as well #4097

@siddharthkp siddharthkp changed the title SelectPanel2: Use Tooltip v2 [Do not merge] SelectPanel2: Use Tooltip v2 Jan 22, 2024
@siddharthkp
Copy link
Member Author

@siddharthkp siddharthkp closed this Mar 7, 2024
@siddharthkp siddharthkp deleted the drafts-selectpanel-tooltip2 branch October 4, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants