Skip to content

[Do not merge] SelectPanel2: Use Tooltip v2 #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Do not merge] SelectPanel2: Use Tooltip v2 #4094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5d6d5
Replace Tooltip v1 with Tooltip v2
siddharthkp Dec 20, 2023
0128d1e
Apply feedback
siddharthkp Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/drafts/SelectPanel2/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import {
IconButton,
Heading,
Box,
Tooltip,
TextInput,
TextInputProps,
Spinner,
Text,
ActionListProps,
Octicon,
} from '../../../src/index'
import {Tooltip} from '../../../src/drafts'
import {ActionListContainerContext} from '../../../src/ActionList/ActionListContainerContext'
import {useSlots} from '../../hooks/useSlots'
import {useProvidedRefOrCreate, useId, useAnchoredPosition} from '../../hooks'
Expand Down Expand Up @@ -327,11 +327,11 @@ const SelectPanelHeader: React.FC<React.PropsWithChildren> = ({children, ...prop
<Box>
{/* Will not need tooltip after https://github.com/primer/react/issues/2008 */}
{onClearSelection ? (
<Tooltip text="Clear selection" direction="s" onClick={onClearSelection}>
<IconButton type="button" variant="invisible" icon={FilterRemoveIcon} aria-label="Clear selection" />
<Tooltip text="Clear selection" type="label">
<IconButton type="button" variant="invisible" icon={FilterRemoveIcon} aria-label="Clear selection" onClick={onClearSelection} />
</Tooltip>
) : null}
<Tooltip text="Close" direction="s">
<Tooltip text="Close" type="label">
<IconButton type="button" variant="invisible" icon={XIcon} aria-label="Close" onClick={() => onCancel()} />
</Tooltip>
</Box>
Expand Down