-
Notifications
You must be signed in to change notification settings - Fork 646
chore(tsconfig): update config target and module detection #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
This is a follow-up to: #3920
This PR updates some of the options in our TypeScript config to use newer options or fields that help making developing in TypeScript more consistent and predictable. The changes either come from the PR mentioned above or the corresponding article: https://www.totaltypescript.com/tsconfig-cheat-sheet
Changelog
New
Changed
tsconfig.jsonmoduletoESNextmoduleResolutiontoBundlerisolatedModulestotruemoduleDetectionto'force'tsxinstead ofts-nodeto compile our TypeScript scripts asts-nodewas difficult to work with when using these new settingscolor2kin order to use their new type declarationsRemoved
Rollout strategy
These are only related to our internal config and should not impact the output of Primer React
Testing & Reviewing