Skip to content

Conversation

@mattpocock
Copy link

Update tsconfig.json to recommendations in https://www.totaltypescript.com/tsconfig-cheat-sheet

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mattpocock mattpocock requested review from a team and langermank November 8, 2023 16:03
@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 254119a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack
Copy link
Member

joshblack commented Nov 8, 2023

Hi there @mattpocock! 👋 Just wanted to say thanks so much for taking the time to make a Pull Request with these changes, we appreciate it a ton!

For the CI failures, most likely it's due to us being on TS v4 still, we have a couple of remaining things to fix for moving to v5 over in: #3824

@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 8, 2023
@siddharthkp siddharthkp requested review from joshblack and removed request for langermank November 9, 2023 11:21
@joshblack
Copy link
Member

Seems like the latest challenge is specifically this error in a couple of spots 👀

 error TS2742: The inferred type of 'default' cannot be named without a reference to '../../node_modules/@primer/octicons-react/dist/icons'.
This is likely not portable. A type annotation is necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 8, 2024
@github-actions github-actions bot closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants