Skip to content

Conversation

@agreenberry
Copy link
Contributor

@agreenberry agreenberry commented Aug 15, 2023

Parent issue: https://github.com/github/primer/issues/1488

Add storybook stories for InlineAutocomplete (draft)

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@agreenberry agreenberry requested review from a team and mperrotti August 15, 2023 18:09
@agreenberry agreenberry added the skip changeset This change does not need a changelog label Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (0%)
dist/browser.umd.js 104.13 KB (0%)

@agreenberry agreenberry temporarily deployed to github-pages August 15, 2023 18:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 August 15, 2023 18:18 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

⚠️ No Changeset found

Latest commit: fd3b9b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agreenberry agreenberry temporarily deployed to github-pages August 16, 2023 19:20 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 August 16, 2023 19:21 Inactive
@agreenberry agreenberry temporarily deployed to github-pages August 23, 2023 14:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 August 23, 2023 14:36 Inactive
@broccolinisoup
Copy link
Member

Hello @green6erry would that be possible to resolve the merge conflicts before the review? Thank you 🙏🏻

@agreenberry agreenberry temporarily deployed to github-pages September 18, 2023 01:30 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 September 18, 2023 01:30 Inactive
@agreenberry
Copy link
Contributor Author

agreenberry commented Sep 18, 2023

Hello @green6erry would that be possible to resolve the merge conflicts before the review? Thank you 🙏🏻

@broccolinisoup Thanks and done!

@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 13:51 Inactive
@agreenberry
Copy link
Contributor Author

@broccolinisoup, There are issues with naming it back to Drafts/... because of Tooptip v2. I'm not sure how you'd like to delineate between them, but I was just trying to get a story for the v1 Tooltip so there was something. I think it will be up to you or someone that's not me to decide.

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! ✨ Just left some comments on what I think the story ids ended up being with the move, hope they work 🤞

@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:50 Inactive
@agreenberry agreenberry temporarily deployed to github-pages October 31, 2023 15:50 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3639 October 31, 2023 15:51 Inactive
@agreenberry agreenberry requested a review from joshblack October 31, 2023 16:08
Copy link
Contributor Author

@agreenberry agreenberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broccolinisoup this also should be complete.

@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit aa3fde1 Oct 31, 2023
@broccolinisoup broccolinisoup deleted the docs/add-inlineAutocomplete-stories branch October 31, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants