-
Notifications
You must be signed in to change notification settings - Fork 641
Added InlineAutocomplete stories #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
|
|
Hello @green6erry would that be possible to resolve the merge conflicts before the review? Thank you 🙏🏻 |
@broccolinisoup Thanks and done! |
|
@broccolinisoup, There are issues with naming it back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! ✨ Just left some comments on what I think the story ids ended up being with the move, hope they work 🤞
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@broccolinisoup this also should be complete.
Parent issue: https://github.com/github/primer/issues/1488
Add storybook stories for InlineAutocomplete (draft)
Checklist