Skip to content

Commit aa3fde1

Browse files
agreenberrybroccolinisoupjoshblack
authored
Added InlineAutocomplete stories (#3639)
* Added InlineAutocomplete stories * fix story naming convention and merge main * fix unrelated but breaking test * undo relative time update maybe * maybe this time * fix import * more fix imports * another fix imports * another fix imports * fix: update playwright * Update docs/content/drafts/InlineAutocomplete.mdx Co-authored-by: Armağan <[email protected]> * Update src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx Co-authored-by: Armağan <[email protected]> * Update src/InlineAutocomplete/InlineAutocomplete.stories.tsx Co-authored-by: Armağan <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Armağan <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> * Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black <[email protected]> --------- Co-authored-by: Armağan <[email protected]> Co-authored-by: Josh Black <[email protected]>
1 parent e27c3c8 commit aa3fde1

18 files changed

+42
-41
lines changed

‎docs/content/drafts/InlineAutocomplete.mdx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ componentId: inline_autocomplete
44
status: Draft
55
description: Provides inline auto completion suggestions for an input or textarea.
66
source: https://github.com/primer/react/tree/main/src/InlineAutocomplete
7-
storybook: '/react/storybook?path=/story/components-forms-inlineautocomplete--default'
7+
storybook: '/react/storybook?path=/story/drafts-components-inlineautocomplete--default'
88
---
99

10-
import data from '../../../src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json'
10+
import data from '../../../src/InlineAutocomplete/InlineAutocomplete.docs.json'
1111

1212
```js
1313
import {InlineAutocomplete} from '@primer/react/drafts'

‎e2e/components/InlineAutocomplete.test.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test.describe('InlineAutocomplete', () => {
88
test.describe(theme, () => {
99
test('default @vrt', async ({page}) => {
1010
await visit(page, {
11-
id: 'components-forms-inlineautocomplete--default',
11+
id: 'drafts-components-inlineautocomplete--default',
1212
globals: {
1313
colorScheme: theme,
1414
},
@@ -20,7 +20,7 @@ test.describe('InlineAutocomplete', () => {
2020

2121
test('axe @aat', async ({page}) => {
2222
await visit(page, {
23-
id: 'components-forms-inlineautocomplete--default',
23+
id: 'drafts-components-inlineautocomplete--default',
2424
globals: {
2525
colorScheme: theme,
2626
},
@@ -36,7 +36,7 @@ test.describe('InlineAutocomplete', () => {
3636
test.describe(theme, () => {
3737
test('default @vrt', async ({page}) => {
3838
await visit(page, {
39-
id: 'components-forms-inlineautocomplete--playground',
39+
id: 'drafts-components-inlineautocomplete--playground',
4040
globals: {
4141
colorScheme: theme,
4242
},
@@ -48,7 +48,7 @@ test.describe('InlineAutocomplete', () => {
4848

4949
test('axe @aat', async ({page}) => {
5050
await visit(page, {
51-
id: 'components-forms-inlineautocomplete--playground',
51+
id: 'drafts-components-inlineautocomplete--playground',
5252
globals: {
5353
colorScheme: theme,
5454
},
@@ -64,7 +64,7 @@ test.describe('InlineAutocomplete', () => {
6464
test.describe(theme, () => {
6565
test('default @vrt', async ({page}) => {
6666
await visit(page, {
67-
id: 'components-forms-inlineautocomplete-features--custom-rendering',
67+
id: 'drafts-components-inlineautocomplete-features--custom-rendering',
6868
globals: {
6969
colorScheme: theme,
7070
},
@@ -76,7 +76,7 @@ test.describe('InlineAutocomplete', () => {
7676

7777
test('axe @aat', async ({page}) => {
7878
await visit(page, {
79-
id: 'components-forms-inlineautocomplete-features--custom-rendering',
79+
id: 'drafts-components-inlineautocomplete-features--custom-rendering',
8080
globals: {
8181
colorScheme: theme,
8282
},
@@ -92,7 +92,7 @@ test.describe('InlineAutocomplete', () => {
9292
test.describe(theme, () => {
9393
test('default @vrt', async ({page}) => {
9494
await visit(page, {
95-
id: 'components-forms-inlineautocomplete-features--single-line',
95+
id: 'drafts-components-inlineautocomplete-features--single-line',
9696
globals: {
9797
colorScheme: theme,
9898
},
@@ -104,7 +104,7 @@ test.describe('InlineAutocomplete', () => {
104104

105105
test('axe @aat', async ({page}) => {
106106
await visit(page, {
107-
id: 'components-forms-inlineautocomplete-features--single-line',
107+
id: 'drafts-components-inlineautocomplete-features--single-line',
108108
globals: {
109109
colorScheme: theme,
110110
},

‎src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json‎ renamed to ‎src/InlineAutocomplete/InlineAutocomplete.docs.json‎

File renamed without changes.

‎src/drafts/InlineAutocomplete/InlineAutocomplete.features.stories.tsx‎ renamed to ‎src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import React, {useState} from 'react'
22
import {Meta} from '@storybook/react'
3-
import {ActionList, Avatar, ActionListItemProps, Textarea, TextInput, FormControl} from '../..'
3+
import {ActionList, Avatar, ActionListItemProps, Textarea, TextInput, FormControl} from '..'
44
import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.'
55

66
export default {
7-
title: 'Components/Forms/InlineAutocomplete/Features',
7+
title: 'Drafts/Components/InlineAutocomplete/Features',
88
component: InlineAutocomplete,
99
} as Meta<typeof InlineAutocomplete>
1010

‎src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx‎ renamed to ‎src/InlineAutocomplete/InlineAutocomplete.stories.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React, {useState} from 'react'
22
import {Meta} from '@storybook/react'
33

4-
import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '../..'
4+
import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '..'
55
import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.'
66

77
export default {
8-
title: 'Components/Forms/InlineAutocomplete',
8+
title: 'Drafts/Components/InlineAutocomplete',
99
component: InlineAutocomplete,
1010
decorators: [
1111
Story => {

‎src/drafts/InlineAutocomplete/InlineAutocomplete.test.tsx‎ renamed to ‎src/InlineAutocomplete/InlineAutocomplete.test.tsx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import React, {useState} from 'react'
22
import {fireEvent, render, within} from '@testing-library/react'
33
import userEvent from '@testing-library/user-event'
44
import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions, Trigger} from '.'
5-
import FormControl from '../../FormControl'
6-
import {ActionList} from '../../ActionList'
7-
import Textarea from '../../Textarea'
8-
import ThemeProvider from '../../ThemeProvider'
9-
import useIsomorphicLayoutEffect from '../../utils/useIsomorphicLayoutEffect'
5+
import FormControl from '../FormControl'
6+
import {ActionList} from '../ActionList'
7+
import Textarea from '../Textarea'
8+
import ThemeProvider from '../ThemeProvider'
9+
import useIsomorphicLayoutEffect from '../utils/useIsomorphicLayoutEffect'
1010

1111
const label = 'Inline Autocomplete'
1212

‎src/drafts/InlineAutocomplete/InlineAutocomplete.tsx‎ renamed to ‎src/InlineAutocomplete/InlineAutocomplete.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import React, {cloneElement, useRef} from 'react'
2-
import Box from '../../Box'
3-
import Portal from '../../Portal'
4-
import {BetterSystemStyleObject} from '../../sx'
5-
import {useSyntheticChange} from '../hooks/useSyntheticChange'
6-
import {getAbsoluteCharacterCoordinates} from '../utils/character-coordinates'
2+
import Box from '../Box'
3+
import Portal from '../Portal'
4+
import {BetterSystemStyleObject} from '../sx'
5+
import {useSyntheticChange} from '../drafts/hooks/useSyntheticChange'
6+
import {getAbsoluteCharacterCoordinates} from '../drafts/utils/character-coordinates'
77

88
import {
99
SelectSuggestionsEvent,
@@ -16,9 +16,9 @@ import {
1616
} from './types'
1717
import {augmentHandler, calculateSuggestionsQuery, getSuggestionValue, requireChildrenToBeInput} from './utils'
1818

19-
import {useRefObjectAsForwardedRef} from '../../hooks'
19+
import {useRefObjectAsForwardedRef} from '../hooks'
2020
import AutocompleteSuggestions from './_AutocompleteSuggestions'
21-
import {useFormControlForwardedProps} from '../../FormControl'
21+
import {useFormControlForwardedProps} from '../FormControl'
2222

2323
export type InlineAutocompleteProps = {
2424
/** Register the triggers that can cause suggestions to appear. */

‎src/drafts/InlineAutocomplete/_AutocompleteSuggestions.tsx‎ renamed to ‎src/InlineAutocomplete/_AutocompleteSuggestions.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import React, {useCallback, useRef, useState} from 'react'
2-
import Spinner from '../../Spinner'
3-
import {ActionList, ActionListItemProps} from '../../ActionList'
4-
import Box from '../../Box'
5-
import {ComboboxCommitEvent, useCombobox} from '../hooks/useCombobox'
6-
import Overlay from '../../Overlay'
2+
import Spinner from '../Spinner'
3+
import {ActionList, ActionListItemProps} from '../ActionList'
4+
import Box from '../Box'
5+
import {ComboboxCommitEvent, useCombobox} from '../drafts/hooks/useCombobox'
6+
import Overlay from '../Overlay'
77

88
import {Suggestion, Suggestions, SuggestionsPlacement, TextInputElement} from './types'
99
import {getSuggestionKey, getSuggestionValue} from './utils'
10-
import {CharacterCoordinates} from '../utils/character-coordinates'
11-
import useIsomorphicLayoutEffect from '../../utils/useIsomorphicLayoutEffect'
10+
import {CharacterCoordinates} from '../drafts/utils/character-coordinates'
11+
import useIsomorphicLayoutEffect from '../utils/useIsomorphicLayoutEffect'
1212

1313
type AutoCompleteSuggestionsProps = {
1414
suggestions: Suggestions | null

‎src/drafts/InlineAutocomplete/index.ts‎ renamed to ‎src/InlineAutocomplete/index.ts‎

File renamed without changes.

‎src/drafts/InlineAutocomplete/types.ts‎ renamed to ‎src/InlineAutocomplete/types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ActionListItemProps} from '../../ActionList'
1+
import {ActionListItemProps} from '../ActionList'
22

33
export type Trigger = {
44
/** A single character that can cause the suggestion list to open. */

0 commit comments

Comments
 (0)