Skip to content

feat(DataTable): add TableContainer, Title, Subtitle #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2023
Merged

feat(DataTable): add TableContainer, Title, Subtitle #2867

merged 4 commits into from
Feb 6, 2023

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Feb 6, 2023

This is a follow-up to #2839 and #2849 after running into some git challenges 😅

@joshblack joshblack requested review from a team and JoshBowdenConcepts February 6, 2023 20:14
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4887068

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 89.59 KB (0%)
dist/browser.umd.js 90.22 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-2867 February 6, 2023 20:21 Inactive
@primer primer bot temporarily deployed to github-pages February 6, 2023 20:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2867 February 6, 2023 20:22 Inactive
@joshblack joshblack temporarily deployed to github-pages February 6, 2023 21:09 — with GitHub Actions Inactive
@joshblack
Copy link
Member Author

joshblack commented Feb 6, 2023

Going to merge this in since #2839 and #2849 were both approved and CI is green

@joshblack joshblack merged commit 9f731ee into main Feb 6, 2023
@joshblack joshblack deleted the feat/add-table-title-subtitle-row-hover branch February 6, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshBowdenConcepts JoshBowdenConcepts Awaiting requested review from JoshBowdenConcepts

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshblack