-
Notifications
You must be signed in to change notification settings - Fork 646
feat(DataTable): add support for title and subtitle #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
ericwbailey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a TypeScript expert, but this looks good from my perspective.
colebemis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a couple comments about using design tokens
Co-authored-by: Cole Bemis <[email protected]>
Co-authored-by: Cole Bemis <[email protected]>
4130994 to
c921bd8
Compare
Add support for title and subtitle for
DataTablebased on: https://github.com/github/primer/pull/1712This PR adds in
TableContainer,TableTitle, andTableSubtitlealong with documentation to link the title and subtitle to a table. This work does not include support for table actions.This work differs from the API doc in that
TableContaineris being used for the overall container where-as I believeDataTablewas the containing element in the proposal. Currently,DataTableis used to represent the table itself. Naming seems to be something we can address outside of this PR, instead this is meant to:Changelog
New
TableContainercomponent for laying out the tableTableTitlecomponent for providing a table titleTableSubtitlecomponent for providing a table descriptionDataTableChanged
TableTitleandTableSubtitlefor labeling and describing aTableDataTableto includeTableContainer,TableTitle, andTableSubtitleRemoved