Fix new select panel issues #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…ct-panel' into select-panel-fixes
…ct-panel' into select-panel-fixes
…ct-panel' into select-panel-fixes
hectahertz
approved these changes
Jun 28, 2022
Contributor
hectahertz
left a comment
hectahertz
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for contributing these fixes 🙂.
hectahertz
added a commit
that referenced
this pull request
Aug 25, 2022
* Change deprecated/ActionList semantics * Remove item selection via Enter key * Handle focus on deprecated/ActionList * Adapt deprecated/ActionMenu prop * Update deprecated/ActionList tests and stories * Update deprecated/ActionList docs * Remove focusZone from the FilteredActionList component * Add sr-only description for input in the FilteredActionList component * Adapt SelectPanel: semantics, visual layout, add title, close button, save/cancel button and functionality. Update tests, docs, and stories. * Update SelectPanel test snap * Update deprecated/ActionList axe test * Update deprecated/ActionList axe test * Delete commented code * Update stories, Add ESC reset functionality * Add changeset (breaking change) * Preselect items on the SelectPanel docs that aren't the first ones * Use Heading instead of h1 on SelectPanel * Don't use selected items as the SelectPanel anchor label * Replace custom SrOnly with VisuallyHidden * Make the SelectPanel example dimensions larger * Support setting the selected items asyncronously * Fix new select panel issues (#2147) * Fix onClose being called with event instead of gesture Co-authored-by: Hector Garcia <[email protected]> * Remove unsupported PageUpDown bindkeys from useFocusZone * Remove console.debug * Make `title` and `inputLabel` optional with defaults * Remove unused prop * Add a placeholder prop for the search input * Make footer buttons smaller * Use `ButtonClose` * Better default title for multiselect `SelectPanel` * Fix lint warnings * Fix the AutocompleteMenu tests * Fix lint error * Fix MarkdownEditor tests, remove one for old behavior Co-authored-by: Hector Garcia <[email protected]> Co-authored-by: Cameron McHenry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bolonio @hectahertz While integrating with our app, I found a couple of issues that should be addressed.
SelectPanelhas already started rendering, then the selected state does not appear as expected. Adding an effect to ensure that the internal selection state stays synchronized if the external selections change makes this work as expected.AnchoredOverlay, and one for the close/cancel buttons ensures that we always pass the gesture string correctly.