SelectPanel: Accessibility remediation #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 23, 2022 11:11
… save/cancel button and functionality. Update tests, docs, and stories.
🦋 Changeset detectedLatest commit: b828d90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
bolonio
force-pushed
the
primer/issues/1021/reeact-select-panel
branch
from
d0d1eca to
f851e04
Compare
bolonio
changed the title
colebemis
approved these changes
Aug 22, 2022
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Awesome work! Thank you, @hectahertz. Looks like there are a few linting errors that need to be fixed. Approving in advance 👍
colebemis
changed the title
Merged
broccolinisoup
added a commit
that referenced
this pull request
Sep 14, 2022
This reverts commit ace38af.
broccolinisoup
added a commit
that referenced
this pull request
Sep 20, 2022
* Revert "SelectPanel: Accessibility remediation (#2138)" This reverts commit ace38af. * add changeset * Update .changeset/stupid-knives-arrive.md Co-authored-by: Brendan Forster <[email protected]> Co-authored-by: Brendan Forster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses the changes derived from:
The Accessibility engineering review has more details on the reasoning behind all changes.
Screenshots
Merge checklist