Skip to content

Add aria-hidden to InputLabel required asterisk #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Add aria-hidden to InputLabel required asterisk #1770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f880359
add aria-hidden
PeterYangIO Jan 5, 2022
d337d06
fix broken link
PeterYangIO Jan 5, 2022
6da5f4e
add changeset
PeterYangIO Jan 5, 2022
837984b
Merge branch 'main' into users/peteryangio/label-aria-hidden
siddharthkp Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-coats-play.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Adds aria-hidden="true" to InputLabel required asterisk
2 changes: 1 addition & 1 deletion docs/content/InputField.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ componentId: inputField
title: InputField
status: Alpha
description: The InputField component is used to render a labelled text input and, optionally, associated validation text and hint text.
source: https://github.com/primer/react/blob/main/src/InputField.tsx
source: https://github.com/primer/react/blob/main/src/InputField/InputField.tsx
storybook: '/react/storybook?path=/story/forms-inputfield--text-input-field'
---

Expand Down
2 changes: 1 addition & 1 deletion src/_InputLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const InputLabel: React.FC<Props> = ({children, disabled, required, visuallyHidd
{required ? (
<Box display="flex" as="span">
<Box mr={1}>{children}</Box>
<span>*</span>
<span aria-hidden="true">*</span>
</Box>
) : (
children
Expand Down