Add aria-hidden to InputLabel required asterisk #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 837984b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PeterYangIO
changed the title
siddharthkp
approved these changes
Jan 5, 2022
Member
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Great spot! Thank for taking the time to create a PR :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required asterisk needs the
aria-hidden="true"attribute so that it doesn't get announced by screen readers.I discovered this issue since switching my input components to
<InputField/>caused testing-library'sgetByLabelTextto fail. That selector uses the accessibility tree (as pictured in screenshots) and looks for exact name matches, sogetByLabelText("Name")would fail as the name would be "Name *" and not "Name".I also fixed the broken InputField source link in the docs.
Screenshots
Before, asterisk was included in name property:
After, asterisk is no longer included in name property but still displays properly:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.