Skip to content

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Jun 27, 2022

Should fix #85

In shot this PR adds the following contributions;

  • Add serialization to plotly-resampler figures
    => serialize the plotly-resampler figure with its hf_data and other plotly-resampler properties, allowig pickling & (deep)copy!
    (the support for pickling allows to start processes that show a plotly-resampler figure via spawning)
  • Extend the test-matrix with (1) Windows & macOS, (2) python 3.10

This PR does;

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #87 (126f84a) into main (2ed7423) will decrease coverage by 0.16%.
The diff coverage is 93.02%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   98.12%   97.95%   -0.17%     
==========================================
  Files          10       10              
  Lines         746      784      +38     
==========================================
+ Hits          732      768      +36     
- Misses         14       16       +2     
Impacted Files Coverage Δ
...tly_resampler/figure_resampler/figure_resampler.py 89.18% <83.33%> (-0.82%) ⬇️
...ler/figure_resampler/figure_resampler_interface.py 99.71% <100.00%> (+0.01%) ⬆️
...sampler/figure_resampler/figurewidget_resampler.py 99.01% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed7423...126f84a. Read the comment docs.

@jvdd jvdd requested a review from jonasvdd July 1, 2022 11:32
@jvdd
Copy link
Member Author

jvdd commented Jul 3, 2022

Ready for review @jonasvdd

@jvdd jvdd changed the title 🎚️ add windows & mac-os to test matrix 📦 serialization support + 🎚️ update OS & python version in test-matrix Jul 3, 2022
Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @jvdd! 👏🏼 💪🏼 🤝, If the comments are resolved, a merge should be fine!


if isinstance(figure, BaseFigure): # go.Figure or go.FigureWidget or AbstractFigureAggregator
# A base figure object, we first copy the layout and grid ref
if isinstance(figure, BaseFigure):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason, the inherited docs also generate args and kwargs 🤷🏼
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, this is caused by the inheritence of the FigureWidget class.

@jonasvdd jonasvdd merged commit 1e4e069 into main Jul 11, 2022
@jonasvdd jonasvdd deleted the os_matrix branch July 29, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add windows and mac as platforms to the pytest testing matrix

3 participants