Skip to content

Conversation

@jviide
Copy link
Contributor

@jviide jviide commented Sep 15, 2025

This pull request implements alternative 2 for @preact/signals's useComputed as described in #753: Always use the initial compute function givent to useComputed and only recompute whenever one of the signal dependencies change.

This is a mutually exclusive alternative for #754. At least one of these PRs should be eventually closed without merging.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 7f84527

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@preact/signals Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 7f84527
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/68cc4445731f9300081e4ed8
😎 Deploy Preview https://deploy-preview-755--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally prefer this one, happy with either though.

Similar to the other PR, needs a changeset if we go with it.

@jviide
Copy link
Contributor Author

jviide commented Sep 18, 2025

Thanks, added a changeset.

@JoviDeCroock
Copy link
Member

Closing this as we settled on the other option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants