preact/signals: Update useComputed compute function on rerender #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12b72df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5 tasks
jviide
changed the title
JoviDeCroock
approved these changes
Sep 15, 2025
jviide
force-pushed
the
use-computed-01
branch
from
1dd83d8 to
12b72df
Compare
|
Thanks, added a changeset. |
Merged
JoviDeCroock
added a commit
that referenced
this pull request
Oct 2, 2025
JoviDeCroock
added a commit
that referenced
this pull request
Oct 2, 2025
* Reflect logic from #754 in react * Update little-shoes-talk.md with pull request logic
JoviDeCroock
added a commit
that referenced
this pull request
Oct 19, 2025
This reverts commit 5db1295.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements alternative 1 for @preact/signals's
useComputedas described in #753: Update the compute function on rerender. If the compute function changes, and something is depending on the computed returned byuseComputed, then this causes a recompute down the line.This is a mutually exclusive alternative for #755. At least one of these PRs should be eventually closed without merging.