Skip to content

fix: detect virtualenvs on Windows #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: detect virtualenvs on Windows #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rsconnect/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,13 @@ def create_glob_set(directory, excludes):


def is_environment_dir(directory):
"""Detect whether `directory` is a virtualenv"""

# A virtualenv will have Python at ./bin/python
python_path = join(directory, "bin", "python")
return exists(python_path)
# But on Windows, it's at Scripts\Python.exe
win_path = join(directory, "Scripts", "Python.exe")
return exists(python_path) or exists(win_path)


def list_environment_dirs(directory):
Expand Down